Repository navigation
fix(talos): preserve verifier resource IDs in live observations - #5507
Conversation
Validation at
CodeRabbit's included review window is currently unavailable, as confirmed by its refusal on #5505 at 10:50:55 UTC; no paid review is being requested. The next available review lane will be used. |
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The failed manifest-regression job is classified: the first native snapshot readback fixture hit HTTP 502 while pulling its pinned public tooling image. The remaining five cases using that same image then passed, including the matching-byte control. This is a transient image-delivery failure, not a verifier finding. Once the workflow settles, I will retry only its failed jobs once at this unchanged head; the native proof remains required. |
The complete CI result also exposed a missing Talos upgrade-checklist entry for the new version-specific fixture. Commit |
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Ready for protected delivery at The configured code-quality rule has no readable per-head result and remains |
Why
The verifier observer can report a healthy node's image rules as incorrectly ordered because its input format changes rule identities.
What
Preserves those identities and checks the complete ordered decisions and trust roots accurately, while rejecting malformed or duplicate observations.
Fixes #5506